Re: tracking commit timestamps

From: Andres Freund <andres(at)2ndquadrant(dot)com>
To: Simon Riggs <simon(at)2ndQuadrant(dot)com>
Cc: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Petr Jelinek <petr(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Jaime Casanova <jaime(at)2ndquadrant(dot)com>
Subject: Re: tracking commit timestamps
Date: 2014-11-11 16:19:02
Message-ID: 20141111161902.GI18565@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-www

On 2014-11-11 16:10:47 +0000, Simon Riggs wrote:
> On 4 November 2014 08:23, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
>
> >> 6) Shouldn't any value update of track_commit_timestamp be tracked in
> >> XLogReportParameters? That's thinking about making the commit timestamp
> >> available on standbys as well..
> >
> > Yes, it should.
>
> Agree committs should be able to run on standby, but it seems possible
> to do that without it running on the master.

I don't think that's realistic. It requires WAL to be written in some
cases, so that's not going to work. I also don't think it's a
particularly interesting ability?

> The two should be unconnected.

Why?

> Not sure why we'd want to have parameter changes on master reported?

So it works correctly. We're currently truncating the slru on startup
when the guc is disabled which would cause problems WAL records coming
in from the primary. I think the code also needs some TLC to correctly
work after a failover.

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2014-11-11 16:20:25 Re: tracking commit timestamps
Previous Message Tom Lane 2014-11-11 16:12:20 Re: 9.4RC1 next week

Browse pgsql-www by date

  From Date Subject
Next Message Simon Riggs 2014-11-11 16:20:25 Re: tracking commit timestamps
Previous Message Simon Riggs 2014-11-11 16:10:47 Re: tracking commit timestamps