Re: jsonb format is pessimal for toast compression

From: Andres Freund <andres(at)2ndquadrant(dot)com>
To: Josh Berkus <josh(at)agliodbs(dot)com>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Geoghegan <pg(at)heroku(dot)com>, Claudio Freire <klaussfreire(at)gmail(dot)com>, "David E(dot) Wheeler" <david(at)justatheory(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Jan Wieck <jan(at)wi3ck(dot)info>
Subject: Re: jsonb format is pessimal for toast compression
Date: 2014-09-25 17:20:29
Message-ID: 20140925172029.GK9633@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2014-09-25 10:18:24 -0700, Josh Berkus wrote:
> On 09/25/2014 10:14 AM, Bruce Momjian wrote:
> > On Thu, Sep 25, 2014 at 06:01:08PM +0200, Andres Freund wrote:
> >> But independent of which version is chosen, we *REALLY* need to make the
> >> decision soon. This issue has held up the next beta (like jsonb has
> >> blocked previous beta) for *weeks*.
> >>
> >> Personally it doesn't make me very happy that Heikki and Tom had to be
> >> the people stepping up to fix this.
> >
> > I think there are a few reasons this has been delayed, aside from the
> > scheduling ones:
> >
> > 1. compression issues were a surprise, and we are wondering if
> > there are any other surprises
> > 2. pg_upgrade makes future data format changes problematic
> > 3. 9.3 multi-xact bugs spooked us into being more careful
> >
> > I am not sure what we can do to increase our speed based on these items.
>
> Alternately, this is delayed because:
>
> 1. We have one tested patch to fix the issue.
>
> 2. However, people are convinced that there's a better patch possible.
>
> 3. But nobody is working on this better patch except "in their spare time".
>
> Given this, I once again vote for releasing based on Tom's lengths-only
> patch, which is done, tested, and ready to go.

Heikki's patch is there and polished.

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Korotkov 2014-09-25 17:25:02 Re: KNN-GiST with recheck
Previous Message Josh Berkus 2014-09-25 17:18:24 Re: jsonb format is pessimal for toast compression