| From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | src/backend/replication/Makefile misses -I. |
| Date: | 2014-09-24 15:09:03 |
| Message-ID: | 20140924150903.GO2521@awork2.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
Because of the atomics patch I was building postgres with sun
studio. Turns out vpath builds don't work in that scenario when building
from git. The problem is that the replication Makefile
override CPPFLAGS := -I$(srcdir) $(CPPFLAGS)
includes the source directory, but not the current directory. The other
Makefiles dealing with similar things do:
override CPPFLAGS := -I. -I$(srcdir) $(CPPFLAGS)
which looks right to me.
The current override line is from 9cc2c182fc20d5 in reaction to #6073.
Unless somebody protests I'm going to backpatch the -I. addition back to
9.1.
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2014-09-24 15:24:13 | Re: [v9.5] Custom Plan API |
| Previous Message | Ants Aasma | 2014-09-24 14:56:45 | Re: [REVIEW] Re: Compression of full-page-writes |