Re: 9.5 CF1

On 2014-06-17 12:47:19 -0400, Alvaro Herrera wrote:
> Robert Haas wrote:
> > On Mon, Jun 16, 2014 at 2:36 AM, Abhijit Menon-Sen <ams(at)2ndquadrant(dot)com> wrote:
> > > P.S. If you tag your reviews with [REVIEW] in the Subject, it'll be
> > > easier to keep track of them.
> >
> > I and, I believe, various other people hate that style, because at
> > least in Gmail, it breaks the threading. It is much easier to find
> > things if they are all posted on one thread.
>
> Yes, please don't do that. A simple, normal reply to the message that
> submits the patch is much better from my point of view as a subsequent
> reviewer and committer.

Very much agreed. Especially as many patches have several reviews over
the course of their integration. I think the separate thread suggestion
was made by some former CF manager?

I think it's sometimes, for larger/hotly debated patches, useful to
start anew at significant new version though... 300 message deep threads
get unwiedly.

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services