Re: psql \d+ and oid display

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Dunstan <andrew(at)dunslane(dot)net>, David Johnston <polobo(at)yahoo(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: psql \d+ and oid display
Date: 2014-04-01 15:42:24
Message-ID: 20140401154224.GA15629@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Apr 1, 2014 at 11:30:54AM -0400, Robert Haas wrote:
> > OK, I have now applied the conditional display of "Replica Identity"
> > patch (which is how it was originally coded anyway). The attached patch
> > matches Tom's suggestion of displaying the same OID text, just
> > conditionally.
> >
> > Seeing psql \d+ will have a conditional display line in PG 9.4, making
> > OIDs conditional seems to make sense.
>
> Frankly, I think this is all completely wrong-headed. \d+ should
> display *everything*. That's what the + means, isn't it? Coming up
> with complex rules for which things get shown and which things get
> hidden just makes the output harder to understand, without any
> compensating benefit.

Well, there are lot of _other_ things we could display about the table
that we don't. Are you suggesting we add those too? What about
"Replica Identity"? Should that always display?

The bottom line is we already have complex rules to display only what is
_reasonable_. If you want everything, you have to look at the system
tables.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ Everyone has their own god. +

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2014-04-01 15:56:46 Re: PQputCopyData dont signal error
Previous Message Robert Haas 2014-04-01 15:41:20 Re: Archive recovery won't be completed on some situation.