| From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Kevin Grittner <kgrittn(at)ymail(dot)com>, "D'Arcy J(dot)M(dot) Cain" <darcy(at)druid(dot)net>, Amit Langote <amitlangote09(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: A minor correction in comment in heaptuple.c |
| Date: | 2014-01-28 16:16:16 |
| Message-ID: | 20140128161616.GC18333@awork2.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2014-01-28 11:14:49 -0500, Bruce Momjian wrote:
> On Mon, Jan 27, 2014 at 02:51:59PM -0800, Kevin Grittner wrote:
> > So anyway, *I* would object to applying that; it was meant to
> > illustrate what the comment, if any, should cover; not to be an
> > actual code change. I don't think the change that was pushed helps
> > that comment carry its own weight, either. If we can't do better
> > than that, we should just drop it.
> >
> > I guess I won't try to illustrate a point *that* particular way
> > again....
>
> OK, so does anyone object to removing this comment line?
Let's just not do anything. This is change for changes sake. Not
improving anything the slightest.
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2014-01-28 16:18:26 | Re: Suspicion of a compiler bug in clang: using ternary operator in ereport() |
| Previous Message | Bruce Momjian | 2014-01-28 16:14:49 | Re: A minor correction in comment in heaptuple.c |