Re: [patch] Adding EXTRA_REGRESS_OPTS to all pg_regress invocations

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Christoph Berg <cb(at)df7cb(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [patch] Adding EXTRA_REGRESS_OPTS to all pg_regress invocations
Date: 2013-12-04 15:15:33
Message-ID: 20131204151533.GB17114@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, May 6, 2013 at 11:51:47PM -0700, Christoph Berg wrote:
> "make check" supports EXTRA_REGRESS_OPTS to pass extra options to
> pg_regress, but all the other places where pg_regress is used do not
> allow this. The attached patch adds EXTRA_REGRESS_OPTS to
> Makefile.global.in (for contrib modules) and two more special
> Makefiles (isolation and pg_upgrade).
>
> The use case here is that Debian needs to be able to redirect the unix
> socket directory used to /tmp, because /var/run/postgresql isn't
> writable for the buildd user. The matching part for this inside
> pg_regress is still in discussion here, but the addition of
> EXTRA_REGRESS_OPTS is an independent step that is also useful for
> others, so I'd like to propose it for inclusion.

Thanks, patch applied. This will appear in PG 9.4. I suppose we could
backpatch this but I would need community feedback on that.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ Everyone has their own god. +

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kevin Grittner 2013-12-04 15:22:02 Re: Time-Delayed Standbys
Previous Message Pavel Stehule 2013-12-04 15:02:41 Re: Re: [BUGS] BUG #7873: pg_restore --clean tries to drop tables that don't exist