Re: Properly initialize negative/empty cache entries in relfilenodemap

From: Andres Freund <andres(at)2ndquadrant(dot)com>
To: MauMau <maumau307(at)gmail(dot)com>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Properly initialize negative/empty cache entries in relfilenodemap
Date: 2013-08-29 12:38:09
Message-ID: 20130829123809.GB5277@awork2.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2013-08-29 21:35:13 +0900, MauMau wrote:
> >Andres Freund wrote:
> >>Hi,
> >>
> >>Thanks to the valgrind instrumentation I found a small oversight in the
> >>relfilenodemap patch which is fixed in the attached patch.

> Great! Could anybody find the root cause for the following memory leak
> problem, and if possible, fix this?

> http://www.postgresql.org/message-id/214653D8DF574BFEAA6ED53E545E99E4@maumau

> Heiki helped to solve this and found that pg_statistic entries are left in
> CacheMemoryContext, but we have no idea where and how they are created and
> left. This seems difficult to me.

That doesn't have anything to do with this patch/feature though, has it?
For one, the feature has only been integrated into HEAD after you've
reported the issue, for another, it's not even active unless you use it
the first time.

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2013-08-29 14:05:14 Re: [v9.4] row level security
Previous Message MauMau 2013-08-29 12:35:13 Re: Properly initialize negative/empty cache entries in relfilenodemap