Re: error out when building pg_xlogdump with pgxs

Hi Alvaro,

On 2013-08-27 14:47:49 -0400, Alvaro Herrera wrote:
> Andres Freund wrote:
>
> > pg_xlogdump cannot properly be built with pgxs since it needs a
> > sourcetree around. That already has confused some users...
> >
> > How about the attached patch which will tell it's not supported instead
> > of an ominous build error about files that have no rules?
>
> Hmm, the other option is to ignore USE_PGXS completely and build
> assuming the source tree is always present. That way, if you build the
> whole contrib subdir with USE_PGXS=1, you will end up with all modules
> being built, not stop in the middle with an error. This seems more
> useful to me. We could just add a comment that USE_PGXS is ignored.

What's the point in doing USE_PGXS builds with a full and configured
source present? The only thing I can think of is testing that pgxs
builds are working. In that case it doesn't seem helpful to fake
something into working which is then going to fail for real USE_PGXS
builds (where the original sourcetree won't be at that location
anymore).

Maybe I am missing something?

What we could do is something like:
ifdef USE_PGXS
$(warning "pg_xlogdump cannot be built using pgxs)
else

rest of the build rules

endif

i.e. only warn and do nothing if pgxs is specified so you can still do
make USE_PGXS in the contrib directory.

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services