| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: error out when building pg_xlogdump with pgxs |
| Date: | 2013-08-27 18:47:49 |
| Message-ID: | 20130827184749.GD4933@eldon.alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andres Freund wrote:
> pg_xlogdump cannot properly be built with pgxs since it needs a
> sourcetree around. That already has confused some users...
>
> How about the attached patch which will tell it's not supported instead
> of an ominous build error about files that have no rules?
Hmm, the other option is to ignore USE_PGXS completely and build
assuming the source tree is always present. That way, if you build the
whole contrib subdir with USE_PGXS=1, you will end up with all modules
being built, not stop in the middle with an error. This seems more
useful to me. We could just add a comment that USE_PGXS is ignored.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2013-08-27 18:56:54 | Re: pg_restore multiple --function options |
| Previous Message | Boszormenyi Zoltan | 2013-08-27 18:34:21 | Re: Extension Templates S03E11 |