From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
---|---|
To: | Josh Berkus <josh(at)agliodbs(dot)com> |
Cc: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Jim Nasby <jim(at)nasby(dot)net>, Greg Stark <stark(at)mit(dot)edu>, Hannu Krosing <hannu(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: pg_system_identifier() |
Date: | 2013-08-26 18:45:46 |
Message-ID: | 20130826184546.GB5464@awork2.anarazel.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
On 2013-08-26 10:10:54 -0700, Josh Berkus wrote:
> I think we've gotten a bit off the track of the proposed patch, which is
> designed to report the system_identifier string currently in
> pg_controldata, nothing more.
Agreed.
> I'm going to reverse my vote, and vote against this patch. The reason
> why is that I think we should instead have a function:
>
> pg_controldata(parameter text)
>
> ... which would report *all* strings in pg_controldata. Hence, you'd do
> instead:
>
> pg_controldata('system identifier')
>
> This will hopefully spare us from 15 patches incrementally adding all of
> the individual items in controldata.
If anything but the proposed feature, it should be an SRF - passing in
text parameters isn't very discoverable. And I can't imagine where an
SRF would have too high overhead.
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2013-08-26 19:04:43 | Re: [9.3 doc fix] clarification of Solaris versions |
Previous Message | Robert Haas | 2013-08-26 18:34:21 | Re: [9.3 doc fix] clarification of Solaris versions |