| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
| Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Fix errcontext() function |
| Date: | 2012-11-12 15:52:59 |
| Message-ID: | 20121112155259.GC4506@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Heikki Linnakangas wrote:
> On 10.11.2012 11:46, Chen Huajun wrote:
> >>Unfortunately not all compilers support varargs macros. I bumped into
> >>this in February, see
> >>http://archives.postgresql.org/message-id/4F3B72E0.8040801@enterprisedb.com.
> >>My last attempt to fix this was
> >>at http://archives.postgresql.org/pgsql-hackers/2012-04/msg00812.php.
> >>That patch is probably good to go, I just got busy with other things
> >>and forgot about it back then. Can you take a look at that
> >>patch and see if I missed anything, please?
> >
> >I think you are right,although the number of changed place is a a little
> >bit large.
> >Thanks for your answer!
>
> Ok, I've committed this patch now, it will be fixed in 9.3. Thanks
> for reminding me about this.
Hopefully you noticed that contrib is broken.
--
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dimitri Fontaine | 2012-11-12 16:00:08 | Dumping an Extension's Script |
| Previous Message | Andres Freund | 2012-11-12 15:42:10 | Re: Inadequate thought about buffer locking during hot standby replay |