Re: WIP pgindent replacement

On Fri, Aug 3, 2012 at 08:26:50AM -0400, Andrew Dunstan wrote:
>
> On 08/02/2012 11:09 PM, Bruce Momjian wrote:
>
> >Thirteen months after Andrew posted this WIP, I have restructured and
> >tested this code, and it is now ready to replace the pgindent shell
> >script as pgindent.pl, attached.
> >
> >I have tested this version by re-running the 9.1 and 9.2 pgindent runs
> >and comparing the output, and it is just like Andrew said --- it is the
> >same, except for the two improvements he mentioned.
> >
> >A Perl version of pgindent has several advantages:
> >
> >* more portable; less dependent on utility command variances
> >* able to run on Windows, assuming someone makes entab and
> > pg_bsd_indent Windows binaries
> >* able to fix more limitations of pgindent
> >
> >I will add documentation about the arguments.
> >
> >Many thanks to Andrew for his fine work on this. Any objections?
>
>
> Thanks for not forgetting this.
>
> I think we generally don't put file type extensions on commands, so
> this should probably just be renamed pgindent. If someone wants to
> go back to the old shell script they can still get it from git.

Of course. I was just noticing that most of the Perl scripts in
/src/tools and src/tools/msvc have a .pl extension on the file name, so
I was following that style. Is that valid?

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +