| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Josh Berkus <josh(at)agliodbs(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Dan Ports <drkp(at)csail(dot)mit(dot)edu>, Kevin Grittner <kevin(dot)grittner(at)wicourts(dot)gov>, andrew <andrew(at)dunslane(dot)net>, cbbrowne <cbbrowne(at)gmail(dot)com>, greg <greg(at)2ndquadrant(dot)com> |
| Subject: | Re: Formatting Curmudgeons WAS: MMAP Buffers |
| Date: | 2011-04-20 19:34:46 |
| Message-ID: | 201104202134.46783.andres@anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wednesday, April 20, 2011 08:53:34 PM Andres Freund wrote:
> On Wednesday, April 20, 2011 08:50:04 PM Tom Lane wrote:
> > > I think we should put less temporal emphasis on the finishing part, but
> > > use the time better. I would imagine one commit fest per month, but
> > > it's only a week long. Then everyone can really concentrate on the
> > > commit fest, people get faster feedback, but there is ultimately more
> > > time to do other things. Something to think about.
> >
> > Yeah, maybe. To do that, we'd have to strongly resist the temptation to
> > spend a lot of time fixing up submitted patches --- if it's not pretty
> > darn close to committable, back it goes. But that might be a good thing
> > all around. I find this idea attractive.
>
> Actually as a patch submitter I would somewhat prefer that as well. Its not
> exactly easy to learn what wasn't optimal with your patch at times.
Perhaps we should adapt something like the kernel's checkpatch.pl for our
needs?
I.e. something that checks that the most obvious style issues are addressed
(tabs, trailing whitespaces, spacing around braces etc).
Andres
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2011-04-20 19:35:16 | Re: Formatting Curmudgeons WAS: MMAP Buffers |
| Previous Message | Robert Haas | 2011-04-20 19:23:44 | Re: pgbench \for or similar loop |