From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
---|---|
To: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: actualised funcs typmod patch |
Date: | 2009-11-12 23:07:53 |
Message-ID: | 20091112230753.GM4780@alvh.no-ip.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Pavel Stehule escribió:
> Hello
>
> actualised version: enhance check inside sql function
What is this against? It has a few suspicious chunks, such as
***************
*** 358,364 ****
funcexpr->funcid = funcid;
funcexpr->funcresulttype = rettype;
! funcexpr->funcresulttypmod = -1; // TODO STEHULE
funcexpr->funcretset = retset;
funcexpr->funcformat = COERCE_EXPLICIT_CALL;
funcexpr->args = fargs;
--- 365,371 ----
funcexpr->funcid = funcid;
funcexpr->funcresulttype = rettype;
! funcexpr->funcresulttypmod = rettypmod;
funcexpr->funcretset = retset;
funcexpr->funcformat = COERCE_EXPLICIT_CALL;
funcexpr->args = fargs;
This ended up in ./src/backend/parser/parse_func.c.rej
There are other rejects and I'm not sure if I should fix them (at least
the first couple look trivial, though it's against a bunch of code
that last changed in Aug. last year) or ask for a better version ...
--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
From | Date | Subject | |
---|---|---|---|
Next Message | Greg Sabino Mullane | 2009-11-12 23:16:20 | Re: EOL for 7.4? |
Previous Message | Tom Lane | 2009-11-12 23:07:25 | Re: ALTER TABLE...ALTER COLUMN vs inheritance |