From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
---|---|
To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: actualised funcs typmod patch |
Date: | 2009-11-15 18:08:04 |
Message-ID: | 162867790911151008m6af2a265ic608af1149922021@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hello
I am sending actualised patch. Sorry - I am late, I am ill.
Regards
Pavel Stehule
2009/11/13 Alvaro Herrera <alvherre(at)commandprompt(dot)com>:
> Pavel Stehule escribió:
>> Hello
>>
>> actualised version: enhance check inside sql function
>
> What is this against? It has a few suspicious chunks, such as
>
> ***************
> *** 358,364 ****
>
> funcexpr->funcid = funcid;
> funcexpr->funcresulttype = rettype;
> ! funcexpr->funcresulttypmod = -1; // TODO STEHULE
> funcexpr->funcretset = retset;
> funcexpr->funcformat = COERCE_EXPLICIT_CALL;
> funcexpr->args = fargs;
> --- 365,371 ----
>
> funcexpr->funcid = funcid;
> funcexpr->funcresulttype = rettype;
> ! funcexpr->funcresulttypmod = rettypmod;
> funcexpr->funcretset = retset;
> funcexpr->funcformat = COERCE_EXPLICIT_CALL;
> funcexpr->args = fargs;
>
>
>
> This ended up in ./src/backend/parser/parse_func.c.rej
>
> There are other rejects and I'm not sure if I should fix them (at least
> the first couple look trivial, though it's against a bunch of code
> that last changed in Aug. last year) or ask for a better version ...
>
> --
> Alvaro Herrera http://www.CommandPrompt.com/
> PostgreSQL Replication, Consulting, Custom Development, 24x7 support
>
Attachment | Content-Type | Size |
---|---|---|
proargtypmodes151109.diff.gz | application/x-gzip | 105.9 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | George Gensure | 2009-11-15 18:09:56 | Re: patch - Report the schema along table name in a referential failure error message |
Previous Message | Pavel Stehule | 2009-11-15 17:54:08 | Re: named parameters in SQL functions |