| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Report which WAL sync method we are trying to change *to* when it |
| Date: | 2008-05-12 19:49:15 |
| Message-ID: | 20080512214915.08155e60@mha-laptop.hagander.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Simon Riggs wrote:
> On Mon, 2008-05-12 at 15:26 -0400, Tom Lane wrote:
> > Magnus Hagander <magnus(at)hagander(dot)net> writes:
> > > Simon Riggs wrote:
> > >> Could we report both?
> >
> > > Yes, we could easily do that if we want to.
> >
> > It would be entirely silly to do so, since (a) the old value hasn't
> > been changed if we fail here, and (b) it's irrelevant to the nature
> > of the error.
>
> That's reasonable. If it is impossible to set it to an
> impossible/failing value then that is even better.
>
> Magnus seems to say it is possible to set this and then have it fail
> later when it is used. Not sure which is correct.
It shouldn't ever happen. It happened here because there was a bug in
my original patch, that has now been fixed. So unless there are more
bugs in it, it is now back to can't happen.
//Magnus
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2008-05-12 19:49:31 | Re: pgsql: Report which WAL sync method we are trying to change *to* when it |
| Previous Message | Magnus Hagander | 2008-05-12 19:47:03 | Re: [COMMITTERS] pgsql: Convert wal_sync_method to guc enum. |