Re: [COMMITTERS] pgsql: Convert wal_sync_method to guc enum.

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [COMMITTERS] pgsql: Convert wal_sync_method to guc enum.
Date: 2008-05-12 19:47:03
Message-ID: 20080512214703.4d5ac47e@mha-laptop.hagander.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Tom Lane wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
> > I need to leave for a couple of hours, will look again when I get
> > back. But so far, I'm quite surprised. Here's my reasoning, please
> > poke holes in it :-)
>
> I think you forgot to handle SYNC_METHOD_OPEN_DSYNC in
> issue_xlog_fsync. If you are going to split SYNC_METHOD_OPEN into two
> codes, you need to handle both those codes everywhere
> SYNC_METHOD_OPEN was formerly referenced ...

That was it, fixed. I missed the fact that the same error message
occured twice in the file.

I blame lack of caffeine comined with having hacked Latex code. It just
kills the brain.

Thanks for the pointer!

//Magnus

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Magnus Hagander 2008-05-12 19:49:15 Re: pgsql: Report which WAL sync method we are trying to change *to* when it
Previous Message Simon Riggs 2008-05-12 19:46:12 Re: pgsql: Report which WAL sync method we are trying to change *to* when it

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2008-05-12 19:47:08 Re: Syntax decisions for pl/pgsql RAISE extension
Previous Message Alvaro Herrera 2008-05-12 19:26:56 Re: bloated heapam.h