Typo in ginxlog.c

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Typo in ginxlog.c
Date: 2006-05-02 19:01:06
Message-ID: 20060502190106.GA17285@surnet.cl
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Just noticed a typo in newly added ginxlog.c. I don't have line
numbers, but in ginRedoSplit() it reads:

PageSetLSN(rpage, lsn);
PageSetTLI(lpage, ThisTimeLineID);
MarkBufferDirty(rbuffer);

PageSetLSN(lpage, lsn);
PageSetTLI(lpage, ThisTimeLineID);
MarkBufferDirty(lbuffer);

Notice the first call to PageSetTLI should be

PageSetTLI(rpage, ThisTimeLineID);

I wonder why don't we have a macro or function to do both things in one
pass?

--
Alvaro Herrera http://www.amazon.com/gp/registry/CTMLCN8V17R4
"¿Qué importan los años? Lo que realmente importa es comprobar que
a fin de cuentas la mejor edad de la vida es estar vivo" (Mafalda)

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Martijn van Oosterhout 2006-05-02 19:19:22 Re: patch review, please: Autovacuum/Vacuum times via stats.
Previous Message Larry Rosenman 2006-05-02 18:42:54 Re: [HACKERS] patch review, please: Autovacuum/Vacuum times via stats.