Re: Typo in ginxlog.c

From: Simon Riggs <simon(at)2ndquadrant(dot)com>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Typo in ginxlog.c
Date: 2006-05-04 07:46:54
Message-ID: 1146728814.449.225.camel@localhost.localdomain
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, 2006-05-02 at 15:01 -0400, Alvaro Herrera wrote:
> Just noticed a typo in newly added ginxlog.c. I don't have line
> numbers, but in ginRedoSplit() it reads:
>
> PageSetLSN(rpage, lsn);
> PageSetTLI(lpage, ThisTimeLineID);
> MarkBufferDirty(rbuffer);
>
> PageSetLSN(lpage, lsn);
> PageSetTLI(lpage, ThisTimeLineID);
> MarkBufferDirty(lbuffer);
>
>
> Notice the first call to PageSetTLI should be
>
> PageSetTLI(rpage, ThisTimeLineID);
>

Well spotted. We'd have not corrected that until someone's db failed.

--
Simon Riggs
EnterpriseDB http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Martijn van Oosterhout 2006-05-04 07:59:40 Semi-undocumented functions in libpq
Previous Message Simon Riggs 2006-05-04 07:44:15 Re: Rethinking locking for database create/drop vs