Re: pgsql: Allow the syntax CREATE TYPE foo, with no parameters, to permit

From: Martijn van Oosterhout <kleptog(at)svana(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Neil Conway <neilc(at)samurai(dot)com>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Allow the syntax CREATE TYPE foo, with no parameters, to permit
Date: 2006-03-01 11:57:11
Message-ID: 20060301115711.GA16964@svana.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Wed, Mar 01, 2006 at 01:52:51AM -0500, Tom Lane wrote:
> > if nothing else to avoid the ugly "NOTICE" that is
> > currently emitted in many cases describing the implicit creation of a
> > shell type.
>
> As things currently stand, you'll still get some annoying "NOTICE: foo
> is a shell type" messages from a completely-kosher creation sequence.
> Ideally we should get rid of these, but on the other hand random
> references to an incomplete shell type are probably worth warning
> about. Any thoughts about the best approach here?

Yeah, I know. Currently there is no actual way to distinguish between a
shell type created explicitly and one created inplicitly. As long as we
support the old way there's not a lot we can do about that.

My only thought was that the message could be supressed if the shell
type was created in the same transaction as you are currently running.
In that case wrapping everything in a BEGIN/END would supress all the
messages. I don't know whether this kind of behaviour is desirable
though or if it is even feasable.

Have a nice day,
--
Martijn van Oosterhout <kleptog(at)svana(dot)org> http://svana.org/kleptog/
> Patent. n. Genius is 5% inspiration and 95% perspiration. A patent is a
> tool for doing 5% of the work and then sitting around waiting for someone
> else to do the other 95% so you can sue them.

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2006-03-01 20:31:29 pgsql: Update Japanese FAQ, backpatched to 8.1.X.
Previous Message Tom Lane 2006-03-01 06:52:51 Re: pgsql: Allow the syntax CREATE TYPE foo, with no parameters, to permit