Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: Proposal for Allow postgresql.conf values to be changed via SQL [review])

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Amit kapila <amit(dot)kapila(at)huawei(dot)com>
Cc: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Boszormenyi Zoltan <zb(at)cybertec(dot)at>, Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Josh Berkus <josh(at)agliodbs(dot)com>
Subject: Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: Proposal for Allow postgresql.conf values to be changed via SQL [review])
Date: 2013-07-18 00:47:12
Message-ID: 1374108432.15052.7.camel@vanquo.pezone.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, 2013-07-16 at 04:23 +0000, Amit kapila wrote:
>
> > Why do we need to expose this setting to a user?
>
> a) This can be a knob to turn this feature off. This has been asked by
> few people,
> one of the mail link is mentioned below (refer towards end of mail
> in the link):
> http://www.postgresql.org/message-id/515B04F9.30900@gmx.net
>
> b) In case user wants to change priority of parameters set by Alter
> System, he can move the
> include_dir up or down in postgresql.conf.

In that message I argue that the auto file should always be read
implicitly.

The comment about being able to turn this feature off was because as
presented it was too complicated and error-prone. Removing the include
would incidentally not be a way to turn the feature off. Turning the
feature of would require disabling the ALTER SYSTEM command. I'm not
really asking for that functionality, but I'm really against having to
manually include the auto file, and also against the system nagging me
about including the file.

There is the slightly interesting question whether the auto file should
notionally be processed before or after the main postgresql.conf, but
that's a question we should answer now, not let it the users work it
out.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tatsuo Ishii 2013-07-18 01:16:29 Re: [PATCH] pgbench --throttle (submission 7 - with lag measurement)
Previous Message Peter Eisentraut 2013-07-18 00:39:26 Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: Proposal for Allow postgresql.conf values to be changed via SQL [review])