Re: Materialized views WIP patch

From: Kevin Grittner <kgrittn(at)ymail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, Noah Misch <noah(at)leadboat(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Marko Tiikkaja <pgmail(at)joh(dot)to>, Greg Stark <stark(at)mit(dot)edu>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Materialized views WIP patch
Date: 2013-02-21 15:26:06
Message-ID: 1361460366.71283.YahooMailNeo@web162901.mail.bf1.yahoo.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Kevin Grittner <kgrittn(at)ymail(dot)com> writes:
>> Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> That being the case, lumping them as being the "same"
>>> operation feels like the wrong thing, and so we should choose a
>>> different name for the MV operation.
>>
>> There is currently no truncation of MV data without rendering
>> the MV unscannable.  Do you still feel it needs a different
>> command name?
>
> You didn't say anything that changed my opinion: it doesn't feel
> like a TRUNCATE to me.  It's not changing the object to a
> different but entirely valid state, which is what TRUNCATE does.
>
> Peter claimed upthread that REFRESH is a subcommand of ALTER
> MATERIALIZE VIEW

It's not, nor do I think it should be.

> and that this operation should be another one.  That sounds
> pretty reasonable from here.

That feels completely wrong to me.  For one thing, I can't think of
any ALTER commands to populate or remove data.  What did you think
of the idea of something like DISCARD MATERIALIZED VIEW DATA as a
new statment?  Or maybe RESET MATERIALIZED VIEW?

--
Kevin Grittner
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Kevin Grittner 2013-02-21 15:35:58 Re: Materialized views WIP patch
Previous Message Andres Freund 2013-02-21 15:19:57 Re: Materialized views WIP patch

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2013-02-21 15:30:52 Re: FDW for PostgreSQL
Previous Message Andres Freund 2013-02-21 15:25:57 Re: FDW for PostgreSQL