Re: review: CHECK FUNCTION statement

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
Cc: Petr Jelínek <pjmodos(at)pjmodos(dot)net>, Greg Smith <greg(at)2ndquadrant(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Albe Laurenz <laurenz(dot)albe(at)wien(dot)gv(dot)at>
Subject: Re: review: CHECK FUNCTION statement
Date: 2012-03-03 20:56:23
Message-ID: 1330808068-sup-7527@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


Excerpts from Alvaro Herrera's message of sáb mar 03 16:54:19 -0300 2012:
> Excerpts from Pavel Stehule's message of sáb mar 03 02:25:52 -0300 2012:

> > 3. THE ARE NOT CARET - this is really important

> I am not sure about the caret thingy -- mainly because I don't think it
> works all that well. I don't know how psql does it, but I notice that
> it shows a single line in a multiline query -- so it's not just a matter
> of adding some number of spaces.

I checked how this works in psql. It is upwards of 200 lines of code --
see reportErrorPosition in libpq/fe-protocol3.c. I'm not sure this can
be made to work sensibly here.

--
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeff Janes 2012-03-03 21:15:59 Re: Memory usage during sorting
Previous Message Alvaro Herrera 2012-03-03 20:49:00 poll: CHECK TRIGGER?