Re: review: xml_is_well_formed

On fre, 2010-08-06 at 07:31 -0400, Robert Haas wrote:
> > What about making the function sensitive to the XML OPTION, such
> that:
> >
> > test=# SET xmloption TO DOCUMENT;
> > SET
> > text=# SELECT xml_is_well_formed('foo');
> >
> > xml_is_well_formed
> > --------------------
> > f
> > (1 row)
>
> That will make using this function a huge hassle, won't it? Functions
> that do different things depending on GUC settings are usually
> troublesome. Having three functions would be more sensible if we need
> all three behaviors, but I don't see why we do.

Upthread you opined that this function should essentially indicate
whether a cast to type xml would succeed, and observing the xmloption is
an essential part of that. I had assumed the original patch actually
did that.