Re: Re: [COMMITTERS] pgsql: Implement current_query(), that shows the currently executing

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Re: [COMMITTERS] pgsql: Implement current_query(), that shows the currently executing
Date: 2008-04-05 00:40:26
Message-ID: 11600.1207356026@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> Bruce Momjian wrote:
>> Alvaro Herrera wrote:
>>> I think the agreement was that dblink_current_query was to be
>>> implemented on top of this. In fact I don't see any reason not to.
>>
>> Really? It seemed like just duplicate functionality.

> It's called "backwards compatibility". The nice thing about it is that
> it doesn't cost us any extra code.

Indeed. It's just silly to break dblink users when there's no need.

>>> Also, wasn't the name supposed to be client_query?
>>
>> Because pg_stat_activity already has current_query (and no one has
>> complained about it) there was discussion to just make it current_query.

> I don't think you can call that an agreement. It was just a suggestion
> IIRC.

Well, there wasn't any strong consensus for client_query either ...

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2008-04-05 00:47:26 Re: Re: [COMMITTERS] pgsql: Implement current_query(), that shows the currently executing
Previous Message Magnus Hagander 2008-04-04 21:35:03 Re: pgsql: Remove no-longer-used function assign_backslash_quote()

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2008-04-05 00:43:00 Re: psql \G command -- send query and output using extended format
Previous Message D'Arcy J.M. Cain 2008-04-05 00:33:03 Re: modules