Re: Minor build nits in 7.3rc1

Hi

1)
configure fails too easily if your libraries and include files are in a
funny place. When you specify --prefix=/somewhere, maybe it should use "-L
/somewhere/lib" and "-I/somewhere/include" by default when checking if
things exist.
Workaround: I had to add the options to LDFLAGS and CPPFLAGS myself to get
readline noticed.

2)
The makefile contains many rm. I usually like to alias rm="rm -i" for
safety, so I had to answer (y/n) a lot of times. Could the makefile please
use rm -f?

Thanks

Peter Harris
Kyndal Spirits

****************************************************************************
This message and any files transmitted with it are confidential.
The contents may not be disclosed or used by anyone other
than the addressee.
If you have received this communication in error, please delete
the message and notify Kyndal International Limited immediately
on 0141-248-5771.

The views expressed in this email are not necessarily the views
of Kyndal International Limited.
As it has been transmitted over a public network,
Kyndal International Limited makes no representation nor accepts
any liability for the email's accuracy or completeness unless
expressly stated to the contrary.

Should you, as the intended recipient, suspect that the message
has been intercepted or amended, please notify
Kyndal International Limited immediately on 0141-248-5771.

****************************************************************************

Harris Peter wrote:
> Hi
>
> 1)
> configure fails too easily if your libraries and include files are in a
> funny place. When you specify --prefix=/somewhere, maybe it should use "-L
> /somewhere/lib" and "-I/somewhere/include" by default when checking if
> things exist.
> Workaround: I had to add the options to LDFLAGS and CPPFLAGS myself to get
> readline noticed.

Yes, I have seen that happen too. Did you use --with-includes and
--with-libs? I have seen cases where the actual compile of the software
honors those flags, but the configure tests don't. Is that what you are
seeing? I think config.log will show you the actual tests.

> 2)
> The makefile contains many rm. I usually like to alias rm="rm -i" for
> safety, so I had to answer (y/n) a lot of times. Could the makefile please
> use rm -f?

That is a little extreme. If we use -f, then you will have rm -if, and
I don't know how that is supposed to behave. Also, if there is an issue
with the rm, I think most will want to see it rather than have -f ignore
it.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

Harris Peter writes:

> Workaround: I had to add the options to LDFLAGS and CPPFLAGS myself to get
> readline noticed.

As you should.

> The makefile contains many rm. I usually like to alias rm="rm -i" for
> safety, so I had to answer (y/n) a lot of times. Could the makefile please
> use rm -f?

It does. Please provide details, in case a spot was missed.

--
Peter Eisentraut peter_e(at)gmx(dot)net

Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> Harris Peter writes:
>> Workaround: I had to add the options to LDFLAGS and CPPFLAGS myself to get
>> readline noticed.

> As you should.

I agree, --prefix should not have anything to do with --with-includes/libs.

>> The makefile contains many rm. I usually like to alias rm="rm -i" for
>> safety, so I had to answer (y/n) a lot of times. Could the makefile please
>> use rm -f?

> It does. Please provide details, in case a spot was missed.

I alias "rm" to "rm -i" also, and I have never seen this happen.
I think Peter H. has got some configuration problem (perhaps he's
somehow overriding make's usual use of /bin/sh to execute commands?)

regards, tom lane