Re: Minor question

Lists: pgsql-novice
From: Jan Danielsson <jan(dot)m(dot)danielsson(at)gmail(dot)com>
To: pgsql-novice(at)postgresql(dot)org
Subject: Minor question
Date: 2007-03-09 10:03:12
Message-ID: 45F130E0.6090809@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-novice

Hello all,

If I perform an update on a table which doesn't contain any rows to
update, should I perform a rollback? I realize that the transaction is
lost when the connection is closed, but is it technically correct to do so?

I have this (psudo code):

-------------------------
UPDATE sessions SET last_access=current_time WHERE id='foo'

if crsr.rowcount == 1:
conn.commit()
else
# No entries found
conn.rollback()
-------------------------

--
Kind regards,
Jan Danielsson


From: Phillip Smith <phillip(dot)smith(at)weatherbeeta(dot)com(dot)au>
To: Jan Danielsson <jan(dot)m(dot)danielsson(at)gmail(dot)com>
Cc: pgsql-novice(at)postgresql(dot)org
Subject: Re: Minor question
Date: 2007-03-09 10:12:20
Message-ID: 1173435140.5301.5.camel@it-laptop
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-novice

I don't believe it would make any difference... NOT doing the rollback
would maybe save a couple of CPU cycles, but unless you're trying to
squeeze EVERY, LAST cycle out of your CPU, I wouldn't bother...

What's the underlying reason you're asking?

Cheers,
~p

On Fri, 2007-03-09 at 11:03 +0100, Jan Danielsson wrote:

> Hello all,
>
> If I perform an update on a table which doesn't contain any rows to
> update, should I perform a rollback? I realize that the transaction is
> lost when the connection is closed, but is it technically correct to do so?
>
> I have this (psudo code):
>
> -------------------------
> UPDATE sessions SET last_access=current_time WHERE id='foo'
>
> if crsr.rowcount == 1:
> conn.commit()
> else
> # No entries found
> conn.rollback()
> -------------------------
>

Phillip Smith
IT Coordinator
Weatherbeeta P/L
8 Moncrief Rd
Nunawading, Vic, 3131
AUSTRALIA

P. +613 9845 0600
F. +613 9845 0655
E. phillip(dot)smith(at)weatherbeeta(dot)com(dot)au