| From: | Jaime Casanova <jaime(at)2ndquadrant(dot)com> |
|---|---|
| To: | Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr> |
| Cc: | Hitoshi Harada <umi(dot)tanuki(at)gmail(dot)com>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: in-catalog Extension Scripts and Control parameters (templates?) |
| Date: | 2013-07-08 04:17:49 |
| Message-ID: | CAJKUy5iYqJozTUsBGk_cuDOm5MZFeWq0vAOJs8b6LMFB=wbrXw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Jul 6, 2013 at 2:25 PM, Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr> wrote:
> Jaime Casanova <jaime(at)2ndquadrant(dot)com> writes:
>> not sure if you're wrong. but at the very least, you miss a
>> heap_freetuple(oldtup) there, because get_catalog_object_by_oid()
>
> Well, oldtup can be either a syscache copy or a heap tuple. I've been
> looking at other call sites and they don't free their tuple either. So
> I'm leaving it at that for now.
>
>> no, that code is not unchanged because function
>> get_ext_ver_list_from_catalog() comes from your patch.
>
> Yes. Here's the relevant hunk:
>
No. That's get_ext_ver_list_from_files() and that function is
unchanged (except for
the name). I'm talking about get_ext_ver_list_from_catalog() which is
a different
function.
--
Jaime Casanova www.2ndQuadrant.com
Professional PostgreSQL: Soporte 24x7 y capacitación
Phone: +593 4 5107566 Cell: +593 987171157
| From | Date | Subject | |
|---|---|---|---|
| Next Message | ivan babrou | 2013-07-08 05:44:32 | Re: Millisecond-precision connect_timeout for libpq |
| Previous Message | Hadi Moshayedi | 2013-07-08 04:14:28 | Re: Improving avg performance for numeric |