Re: Warnings and uninitialized variables in TAP tests

On Mon, Apr 9, 2018 at 3:15 AM, Michael Paquier <michael(at)paquier(dot)xyz> wrote:

> Hi all,
>
> While looking at the output of the TAP tests, I have seen warnings like
> the following:
> Use of uninitialized value $target_lsn in concatenation (.) or string at
> /home/foo/git/postgres/src/bin/pg_rewind/../../../src/
> test/perl/PostgresNode.pm
> line 1540.
> [...]
> ./src/bin/pg_basebackup/tmp_check/log/regress_log_010_pg_basebackup:Use
> of uninitialized value $str in print at
> /home/foo/git/postgres/src/bin/pg_basebackup/../../../
> src/test/perl/TestLib.pm
> line 244.
>
> The first one shows somethng like 30 times, and the second only once.
>
> Attached is a patch to clean up all that. In order to find all that, I
> simply ran the following and they pop up:
> find . -name "regress_log*" | xargs grep -i "uninitialized"
>
> What I have found is harmless, still they pollute the logs.
>

Applied, thanks.

--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>