| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Craig Ringer <craig(at)2ndquadrant(dot)com> |
| Cc: | Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Simon Riggs <simon(dot)riggs(at)2ndquadrant(dot)com> |
| Subject: | Re: Logical decoding on standby |
| Date: | 2017-01-05 05:12:09 |
| Message-ID: | CAB7nPqRjrq640w1hpg+49dGW+d1aQ-DaPxejXN+RJo6O3eoVnA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jan 5, 2017 at 10:21 AM, Craig Ringer <craig(at)2ndquadrant(dot)com> wrote:
> On 5 January 2017 at 09:19, Craig Ringer <craig(at)2ndquadrant(dot)com> wrote:
>
>> so here's a rebased series on top of master. No other changes.
>
> Now with actual patches.
Looking at the PostgresNode code in 0001...
+=pod $node->pg_recvlogical_upto(self, dbname, slot_name, endpos,
timeout_secs, ...)
+
This format is incorrect. I think that you also need to fix the
brackets for the do{} and the eval{] blocks.
+ push @cmd, '--endpos', $endpos if ($endpos);
endpos should be made a mandatory argument. If it is not defined that
would make the test calling this routine being stuck.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | amul sul | 2017-01-05 05:42:51 | Re: background sessions |
| Previous Message | Michael Paquier | 2017-01-05 05:06:56 | Re: PassDownLimitBound for ForeignScan/CustomScan [take-2] |