| From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
|---|---|
| To: | James William Pye <flaw(at)rhid(dot)com> |
| Cc: | Neil Conway <neilc(at)samurai(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: transformExpr() refactor |
| Date: | 2004-11-02 04:16:49 |
| Message-ID: | 200411020416.iA24Gnv06545@candle.pha.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
James William Pye wrote:
-- Start of PGP signed section.
> On Thu, 2004-10-28 at 18:00, Neil Conway wrote:
> > I think the code is more readable this way.
>
> FWIW, I'm +1 on the patch for the above reason.
I liked the large case statement myself. I don't like breaking things
into pieces when the pieces are just splits out of a switch structure.
You are basically giving names to switch actions and pushing into
functions with names.
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kris Jurka | 2004-11-02 04:59:38 | pthread.h header check |
| Previous Message | James William Pye | 2004-11-02 04:08:42 | Re: transformExpr() refactor |