Re: Feedback on writing extensible modules

From: Simon Riggs <simon(at)2ndQuadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Feedback on writing extensible modules
Date: 2009-05-20 20:18:07
Message-ID: 1242850687.27960.197.camel@ebony.2ndQuadrant
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On Wed, 2009-05-20 at 16:03 -0400, Tom Lane wrote:
> Simon Riggs <simon(at)2ndQuadrant(dot)com> writes:
> > 2. shmem_startup_hook doesn't allow multiple modules to create shmem.
> > All callers of the hook think they are the only caller, causing chaos if
> > multiple people need this.
>
> The only known caller, contrib/pg_stat_statements/, does not think that.
> Do what it does.

Hmmm, it works, I guess. As long as everyone does that.

Thanks for the workaround.

> I agree it's undocumented, but so are the other hooks ...

Some are well documented in the code, not all though.

--
Simon Riggs www.2ndQuadrant.com
PostgreSQL Training, Services and Support

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2009-05-20 20:18:45 Re: bootstrap table with TimestampTz type
Previous Message Tom Lane 2009-05-20 20:03:23 Re: Feedback on writing extensible modules