Re: Concurrent psql patch

From: Gregory Stark <stark(at)enterprisedb(dot)com>
To: "Andrew Dunstan" <andrew(at)dunslane(dot)net>
Cc: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "David Fetter" <david(at)fetter(dot)org>, "Jim Nasby" <decibel(at)decibel(dot)org>, "pgsql-patches" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Concurrent psql patch
Date: 2007-05-21 13:21:50
Message-ID: 87ps4ul3bl.fsf@oxford.xeocode.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

"Andrew Dunstan" <andrew(at)dunslane(dot)net> writes:

> Gregory Stark wrote:
>> Attached is an updated patch.
>>
>
> This patch appears to add a nonexistent test to the regression schedules.

I must have forgotten to cvs add it. Sorry.

Also, I forgot to mention previously there is an unrelated trivial hunk in
here. I noticed we free the password early, presumably for security reasons,
but don't actually overwrite the memory at that point. I added a memset in
there, otherwise the free seems kind of pointless. I normally don't bother
with "security" features like that since they don't really add any security
but as long as it's there it may as well do something vaguely useful.

Attachment Content-Type Size
concurrent-psql-v9.patch.gz application/octet-stream 22.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2007-05-21 13:23:30 Re: Re: [Oledb-dev] double precision error with pg linux server, but not with windows pg server
Previous Message Usama Munir 2007-05-21 13:20:48 pg_get_tabledef

Browse pgsql-patches by date

  From Date Subject
Next Message Andrew Dunstan 2007-05-21 13:34:23 Re: UTF8MatchText
Previous Message Heikki Linnakangas 2007-05-21 09:48:59 Re: Maintaining cluster order on insert