From: | tgl(at)postgresql(dot)org (Tom Lane) |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Fix calculation of plan node extParams to account for the |
Date: | 2006-05-03 00:25:07 |
Message-ID: | 20060503002507.562419FB1F8@postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
Log Message:
-----------
Fix calculation of plan node extParams to account for the possibility that one
initPlan sets a parameter for another. This could not (I think) happen before
8.1, but it's possible now because the initPlans generated by MIN/MAX
optimization might themselves use initPlans. We attach those initPlans as
siblings of the MIN/MAX ones, not children, to avoid duplicate computation
when multiple MIN/MAX aggregates are present; so this leads to the case of an
initPlan needing the result of a sibling initPlan, which is not possible with
ordinary query nesting. Hadn't been noticed because in most contexts having
too much stuff listed in extParam is fairly harmless. Fixes "plan should not
reference subplan's variable" bug reported by Catalin Pitis.
Tags:
----
REL8_1_STABLE
Modified Files:
--------------
pgsql/src/backend/optimizer/plan:
subselect.c (r1.100.2.2 -> r1.100.2.3)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/optimizer/plan/subselect.c.diff?r1=1.100.2.2&r2=1.100.2.3)
From | Date | Subject | |
---|---|---|---|
Next Message | Teodor Sigaev | 2006-05-03 06:56:47 | pgsql: Fix typo noticed by Alvaro Herrera |
Previous Message | Tom Lane | 2006-05-03 00:24:57 | pgsql: Fix calculation of plan node extParams to account for the |
From | Date | Subject | |
---|---|---|---|
Next Message | Jim C. Nasby | 2006-05-03 00:38:56 | sblock state on FreeBSD 6.1 |
Previous Message | Jim C. Nasby | 2006-05-02 22:49:33 | Re: patch review, please: Autovacuum/Vacuum times via stats. |