Re: Passing connection string to pg_basebackup

From: Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Amit Kapila <amit(dot)kapila(at)huawei(dot)com>, Boszormenyi Zoltan <zb(at)cybertec(dot)at>, Hari Babu <haribabu(dot)kommi(at)huawei(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Passing connection string to pg_basebackup
Date: 2013-01-19 17:05:02
Message-ID: m2txqd2jep.fsf@2ndQuadrant.fr
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

Magnus Hagander <magnus(at)hagander(dot)net> writes:
>> FWIW, +1. I would consider it a bugfix (backpatch, etc).
>
> While it's a feature I'd very much like to see, I really don't think
> you can consider it a bugfix. It's functionality that was left out -
> it's not like we tried to implement it and it didn't work. We pushed
> the whole implementation to "next version" (and then forgot about
> actually putting it in the next version, until now)

Thanks for reminding me about that, I completely forgot about all that.

On the other hand, discrepancies in between command line arguments
processing in our tools are already not helping our users (even if
pg_dump -d seems to have been fixed along the years); so much so that
I'm having a hard time finding any upside into having a different set of
command line argument capabilities for the same tool depending on the
major version.

We are not talking about a new feature per se, but exposing a feature
that about every other command line tool we ship have. So I think I'm
standing on my position that it should get backpatched as a "fix".

Regards,
--
Dimitri Fontaine
http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2013-01-19 17:33:23 Re: Passing connection string to pg_basebackup
Previous Message Tom Lane 2013-01-19 16:46:27 Re: Query to help in debugging

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2013-01-19 17:33:23 Re: Passing connection string to pg_basebackup
Previous Message Phil Sorber 2013-01-19 17:00:18 Re: My first patch! (to \df output)