Re: Event Triggers: adding information

From: Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr>
To: Thom Brown <thom(at)linux(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Event Triggers: adding information
Date: 2013-01-22 16:53:07
Message-ID: m2r4ldf9cc.fsf@2ndQuadrant.fr
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Thom Brown <thom(at)linux(dot)com> writes:
> ALTER INDEX is missing from the event trigger matrix.
>
> When renaming a column on a foreign table, tg_tag reports 'ALTER
> TABLE' instead of 'ALTER FOREIGN TABLE'. It doesn't do this for any
> other ALTER FOREIGN TABLE operation, including altering, adding or
> dropping a column.

Will see about that later, thanks for reporting.

> DROP OWNED BY doesn't fire any type of event trigger. Is this right?

It's currently being discussed.

> And also I can't get ddl_command_end to do anything:

Due to a bug in the form of a stray & in the patch that got commited,
and that I fixed this morning:

http://www.postgresql.org/message-id/m2vcapl7tl.fsf@2ndQuadrant.fr

> Also, I'm assuming the 'ANY COMMAND' special tag is supposed to be
> removed?

Yes, just omit the WHEN clause for the TAG.

Regards,
--
Dimitri Fontaine
http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Dimitri Fontaine 2013-01-22 16:54:43 Re: Event Triggers: adding information
Previous Message David Fetter 2013-01-22 16:45:12 Patch: clean up addRangeTableEntryForFunction