Re: Event Triggers reduced, v1

From: Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Event Triggers reduced, v1
Date: 2012-07-04 15:00:19
Message-ID: m23957k1vg.fsf@2ndQuadrant.fr
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> No, I'm not asking you to add any more columns right now (in fact,
> please do not). But the type of the existing column should change to
> text[].

Ok, done in the attached. We now read text from either the user input in
the grammar or from the catalogs (in a 1-D array there), and convert to
our enum structure for internal code use.

In fact I attached both the new patch version and the incremental patch
on top of the v1.3 you had before, I suspect that might make life easier
for you. It's of course browsable online too at this URL:

https://github.com/dimitri/postgres/commit/a8cf89116ae7b6e51c8a580510612b85caae2d38

Regards,
--
Dimitri Fontaine
http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support

Attachment Content-Type Size
event_triggers_v1.3--v.1.4.patch text/x-patch 23.7 KB
event_triggers_v1.4.patch.gz application/octet-stream 43.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Joel Jacobson 2012-07-04 15:17:26 [PATCH] pg_dump: Sort overloaded functions in deterministic order
Previous Message Amit Kapila 2012-07-04 14:38:09 Re: [WIP] Patch : Change pg_ident.conf parsing to be the same as pg_hba.conf