From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: don't allow walsender to consume superuser_reserved_connection slots, or during shutdown |
Date: | 2010-04-26 10:54:23 |
Message-ID: | h2x603c8f071004260354s1dfac4aeq79b990eebab67ca8@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Apr 21, 2010 at 9:11 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Wed, Apr 21, 2010 at 1:56 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>>> ...shouldn't we move the "tests", plural, rather than just the one?
>>> It seems right to reject new SR connections during shutdown.
>>
>> Yeah; you'd also need to adjust both of them to consider am_walsender.
>> (IOW, we want to treat SR connections as non-superuser for both tests.)
>
> [ subject changed, recipient list trimmed ]
>
> Here's the fine patch. The actual code changes are simple and seem to
> work as expected, but I struggled a bit with the phrasing of the
> messages. Feel free to suggest improvements. Also, I wasn't sure if
> there was somewhere in the documentation where we discussed the
> restriction that only superusers can connect during shutdown. If
> there is such a place, we should update that, too.
I have committed this as-is. We can further change the error messages
if we like, but there didn't seem to be a clear consensus on any
particular change from what I have here.
...Robert
From | Date | Subject | |
---|---|---|---|
Next Message | Heikki Linnakangas | 2010-04-26 12:05:58 | Re: recovery_connections cannot start (was Re: master in standby mode croaks) |
Previous Message | Robert Haas | 2010-04-26 10:29:19 | Re: recovery_connections cannot start |