| Lists: | pgsql-hackers |
|---|
| From: | 孟庆钟 <1584171677(at)qq(dot)com> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | A very small typo in the comment |
| Date: | 2013-01-04 16:13:27 |
| Message-ID: | tencent_2F442F2F1000EAAC66076843@qq.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Hi,
I am a student in China. I have read some source code of postgreSQL, though only a little. I think maybe there is typo in this file: src\backend\catalog\index.c. At line 649 in v9.2.0, line 653 in V9.2.2. The sentence is " *indexInfo: same info executor uses to insert into the index", I think it should not be 'same', but 'some'.
I am not sure if my thoughts is right.
Sorry for my poor English.
Good Luck From Beijing!
Meng Qingzhong
| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | 孟庆钟 <1584171677(at)qq(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: A very small typo in the comment |
| Date: | 2013-01-08 00:46:46 |
| Message-ID: | 20130108004646.GA18379@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Sat, Jan 5, 2013 at 12:13:27AM +0800, 孟庆钟 wrote:
> Hi,
> I am a student in China. I have read some source code of postgreSQL,
> though only a little. I think maybe there is typo in this file: src\backend\
> catalog\index.c. At line 649 in v9.2.0, line 653 in V9.2.2. The sentence is "
> *indexInfo: same info executor uses to insert into the index", I think it
> should not be 'same', but 'some'.
> I am not sure if my thoughts is right.
> Sorry for my poor English.
You are correct. I have fixed it in the PG 9.3 source tree. Thanks.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ It's impossible for everything to be true. +
| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | 孟庆钟 <1584171677(at)qq(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: A very small typo in the comment |
| Date: | 2013-01-08 00:48:44 |
| Message-ID: | 20130108004844.GB18379@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Mon, Jan 7, 2013 at 07:46:46PM -0500, Bruce Momjian wrote:
> On Sat, Jan 5, 2013 at 12:13:27AM +0800, 孟庆钟 wrote:
> > Hi,
> > I am a student in China. I have read some source code of postgreSQL,
> > though only a little. I think maybe there is typo in this file: src\backend\
> > catalog\index.c. At line 649 in v9.2.0, line 653 in V9.2.2. The sentence is "
> > *indexInfo: same info executor uses to insert into the index", I think it
> > should not be 'same', but 'some'.
> > I am not sure if my thoughts is right.
> > Sorry for my poor English.
>
> You are correct. I have fixed it in the PG 9.3 source tree. Thanks.
Oh, I see Tom's later comment now. The change was not made to 9.3.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ It's impossible for everything to be true. +