Re: [PATCH] explain sortorder

Lists: pgsql-hackers
From: Arne Scheffer <arne(dot)scheffer(at)uni-muenster(dot)de>
To: <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: <marius(dot)timmer(at)uni-muenster(dot)de>, <pgsql-hackers(at)postgresql(dot)org>, <mike(dot)blackwell(at)rrd(dot)com>, <hlinnakangas(at)vmware(dot)com>
Subject: Re: [PATCH] explain sortorder
Date: 2014-12-23 11:11:47
Message-ID: permail-201412231111478954262000006b62-scheffa@message-id.uni-muenster.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

>Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> writes:
>> I would suggest just adding the information to the Sort Key line. As
>> long as you don't print the modifiers when they are defaults (ASC and
>> NULLS LAST), we could print the information even in non-VERBOSE mode.

>+1. I had assumed without looking that that was what it did already,
>else I'd have complained too.

> regards, tom lane

We will change the patch according to Heikkis suggestions.

A nice Christmas & all the best in the New Year

Arne Scheffer

http://www.uni-muenster.de/ZIV/Mitarbeiter/ArneScheffer.shtml


From: Mike Blackwell <mike(dot)blackwell(at)rrd(dot)com>
To: Arne Scheffer <arne(dot)scheffer(at)uni-muenster(dot)de>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Timmer, Marius" <marius(dot)timmer(at)uni-muenster(dot)de>, PgHacker <pgsql-hackers(at)postgresql(dot)org>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>
Subject: Re: [PATCH] explain sortorder
Date: 2014-12-23 16:50:40
Message-ID: CANPAkgtTH31p0a9kC+68KU41_-UVAcVZ=jH_W-FgnxM7T0D2sw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Looking forward to the new patch. I'll give it a more complete testing
when you post it.

Mike

__________________________________________________________________________________
*Mike Blackwell | Technical Analyst, Distribution Services/Rollout
Management | RR Donnelley*
1750 Wallace Ave | St Charles, IL 60174-3401
Office: 630.313.7818
Mike(dot)Blackwell(at)rrd(dot)com
http://www.rrdonnelley.com

<http://www.rrdonnelley.com/>
* <Mike(dot)Blackwell(at)rrd(dot)com>*

On Tue, Dec 23, 2014 at 5:11 AM, Arne Scheffer <
arne(dot)scheffer(at)uni-muenster(dot)de> wrote:

> >Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> writes:
> >> I would suggest just adding the information to the Sort Key line. As
> >> long as you don't print the modifiers when they are defaults (ASC and
> >> NULLS LAST), we could print the information even in non-VERBOSE mode.
>
> >+1. I had assumed without looking that that was what it did already,
> >else I'd have complained too.
>
> > regards, tom lane
>
> We will change the patch according to Heikkis suggestions.
>
> A nice Christmas & all the best in the New Year
>
> Arne Scheffer
>
> http://www.uni-muenster.de/ZIV/Mitarbeiter/ArneScheffer.shtml
>