Re: Author names in source files

I found there are some author names in some of source files.
Will we keep their names? And, will we add new author names
who wrote patches for those files?

src/backend/postmaster/syslogger.c(15) : * Author: Andreas Pflug
src/backend/utils/adt/genfile.c(9) : * Author: Andreas Pflug
src/backend/utils/adt/oracle_compat.c(7): * Author: Edmund Mergl
src/backend/utils/adt/txid.c(14) : * Author: Jan Wieck, Afilias USA INC.

--
Itagaki Takahiro

Itagaki Takahiro wrote:
> I found there are some author names in some of source files.
> Will we keep their names? And, will we add new author names
> who wrote patches for those files?
>
> src/backend/postmaster/syslogger.c(15) : * Author: Andreas Pflug
> src/backend/utils/adt/genfile.c(9) : * Author: Andreas Pflug
> src/backend/utils/adt/oracle_compat.c(7): * Author: Edmund Mergl
> src/backend/utils/adt/txid.c(14) : * Author: Jan Wieck, Afilias USA INC.

When someone writes a file from scratch, we usually keep their name on
it so we remember the original author.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

Excerpts from Bruce Momjian's message of vie dic 03 00:15:28 -0300 2010:
> Itagaki Takahiro wrote:
> > I found there are some author names in some of source files.
> > Will we keep their names? And, will we add new author names
> > who wrote patches for those files?
> >
> > src/backend/postmaster/syslogger.c(15) : * Author: Andreas Pflug
> > src/backend/utils/adt/genfile.c(9) : * Author: Andreas Pflug
> > src/backend/utils/adt/oracle_compat.c(7): * Author: Edmund Mergl
> > src/backend/utils/adt/txid.c(14) : * Author: Jan Wieck, Afilias USA INC.
>
> When someone writes a file from scratch, we usually keep their name on
> it so we remember the original author.

The reason Takahiro-san is asking the question is because one of
Dimitri's patches adds a function to genfile.c, and add his name to the
"Author" field while at it. So answering the second part of the
question is important. I take it your answer to that is "no".

--
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

On 12/02/2010 10:15 PM, Bruce Momjian wrote:
> Itagaki Takahiro wrote:
>> I found there are some author names in some of source files.
>> Will we keep their names? And, will we add new author names
>> who wrote patches for those files?
>>
>> src/backend/postmaster/syslogger.c(15) : * Author: Andreas Pflug
>> src/backend/utils/adt/genfile.c(9) : * Author: Andreas Pflug
>> src/backend/utils/adt/oracle_compat.c(7): * Author: Edmund Mergl
>> src/backend/utils/adt/txid.c(14) : * Author: Jan Wieck, Afilias USA INC.
> When someone writes a file from scratch, we usually keep their name on
> it so we remember the original author.
>

That's probably reasonable for a while. But the code drifts. I certainly
wouldn't object to my name being removed from initdb.c, after 7 years,
athough probably half the code or more is still mine.

cheers

andrew

Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> Excerpts from Bruce Momjian's message of vie dic 03 00:15:28 -0300 2010:
>> When someone writes a file from scratch, we usually keep their name on
>> it so we remember the original author.

> The reason Takahiro-san is asking the question is because one of
> Dimitri's patches adds a function to genfile.c, and add his name to the
> "Author" field while at it. So answering the second part of the
> question is important. I take it your answer to that is "no".

If everybody who had added any code to a file got to put their name on
it, the author lists would be ridiculously long (and some of us would
have our names plastered in hundreds of places). My answer is "no,
and I'm not sure those things should be there in the first place".

regards, tom lane

On Thu, Dec 2, 2010 at 10:57 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
[...]
> My answer is "no,
> and I'm not sure those things should be there in the first place".
>

i agree. after all the committers give the appropiate credit in the
commit message so if we want history it's there

--
Jaime Casanova         www.2ndQuadrant.com
Professional PostgreSQL: Soporte y capacitación de PostgreSQL

On Fri, Dec 3, 2010 at 13:28, Jaime Casanova <jaime(at)2ndquadrant(dot)com> wrote:
> On Thu, Dec 2, 2010 at 10:57 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> [...]
>> My answer is "no,
>> and I'm not sure those things should be there in the first place".
>
> i agree. after all the committers give the appropiate credit in the
> commit message so if we want history it's there

Hi, folks. Thanks for all of your replies.

Dimitri, your name cannot be added in source files,
but will be recorded in commit logs ;-)

--
Itagaki Takahiro

Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com> writes:
> Dimitri, your name cannot be added in source files,
> but will be recorded in commit logs ;-)

Oh, I've only been adding it to src/backend/utils/adt/genfile.c because
I saw another name in there. So of course a stricter following of the
project's copyright and naming here is good news.

BTW, I see you already made that happen (and so much more) in your v9
patch, thank you very much about that! Follow-up due later this morning!

Regards,
--
Dimitri Fontaine
http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support