| Lists: | pgsql-hackers |
|---|
| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | bug in build_startup_packet() |
| Date: | 2010-04-28 12:43:48 |
| Message-ID: | k2h3f0b79eb1004280543h6535fc26z9f294c02f97462c1@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Hi,
We seem to have forgotten to give conn->replication "[0]".
diff --git a/src/interfaces/libpq/fe-protocol3.c
b/src/interfaces/libpq/fe-protocol3.c
index 77cee8a..1956f00 100644
--- a/src/interfaces/libpq/fe-protocol3.c
+++ b/src/interfaces/libpq/fe-protocol3.c
@@ -1909,7 +1909,7 @@ build_startup_packet(const PGconn *conn, char *packet,
ADD_STARTUP_OPTION("user", conn->pguser);
if (conn->dbName && conn->dbName[0])
ADD_STARTUP_OPTION("database", conn->dbName);
- if (conn->replication && conn->replication)
+ if (conn->replication && conn->replication[0])
ADD_STARTUP_OPTION("replication", conn->replication);
if (conn->pgoptions && conn->pgoptions[0])
ADD_STARTUP_OPTION("options", conn->pgoptions);
Regards,
--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: bug in build_startup_packet() |
| Date: | 2010-04-28 13:46:39 |
| Message-ID: | m2h9837222c1004280646v7e7d196bk293f4afd06c2fb75@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Wed, Apr 28, 2010 at 14:43, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> Hi,
>
> We seem to have forgotten to give conn->replication "[0]".
Oops.
Applied, thanks.
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/