| Lists: | pgsql-patches |
|---|
| From: | Jaime Casanova <systemguards(at)gmail(dot)com> |
|---|---|
| To: | pgsql-patches(at)postgresql(dot)org |
| Subject: | Remove second argument from textToQualifiedNameList |
| Date: | 2005-05-26 04:19:03 |
| Message-ID: | c2d9e70e050525211914de5dea@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-patches |
Hi,
i found out that the function textToQualifiedNameList doesn't use the
second argument it receive (caller). i suppose in the past was used
and now it is useless, if that is the case here is a patch removing.
Or are any reasons to keep that argument?
--
regards,
Jaime Casanova
(DBA: DataBase Aniquilator ;)
| Attachment | Content-Type | Size |
|---|---|---|
| textToQualifiedNameList.patch | text/plain | 10.7 KB |
| From: | Neil Conway <neilc(at)samurai(dot)com> |
|---|---|
| To: | Jaime Casanova <systemguards(at)gmail(dot)com> |
| Cc: | pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: Remove second argument from textToQualifiedNameList |
| Date: | 2005-05-26 05:08:46 |
| Message-ID: | 429559DE.60606@samurai.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-patches |
Jaime Casanova wrote:
> i found out that the function textToQualifiedNameList doesn't use the
> second argument it receive (caller). i suppose in the past was used
> and now it is useless, if that is the case here is a patch removing.
> Or are any reasons to keep that argument?
None that I can see. I'll apply the patch later today, barring any
objections.
-Neil
| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Neil Conway <neilc(at)samurai(dot)com> |
| Cc: | Jaime Casanova <systemguards(at)gmail(dot)com>, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: Remove second argument from textToQualifiedNameList |
| Date: | 2005-05-26 05:32:02 |
| Message-ID: | 23736.1117085522@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-patches |
Neil Conway <neilc(at)samurai(dot)com> writes:
> Jaime Casanova wrote:
>> Or are any reasons to keep that argument?
> None that I can see. I'll apply the patch later today, barring any
> objections.
Looking at the 7.3 sources, the argument was used to support the
then-existing convention that an error message include the name
of the reporting routine. This does seem obsolete now.
regards, tom lane
| From: | Neil Conway <neilc(at)samurai(dot)com> |
|---|---|
| To: | Jaime Casanova <systemguards(at)gmail(dot)com> |
| Cc: | pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: Remove second argument from textToQualifiedNameList |
| Date: | 2005-05-27 00:58:28 |
| Message-ID: | 429670B4.7020008@samurai.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-patches |
Jaime Casanova wrote:
> i found out that the function textToQualifiedNameList doesn't use the
> second argument it receive (caller). i suppose in the past was used
> and now it is useless, if that is the case here is a patch removing.
> Or are any reasons to keep that argument?
Applied to HEAD. Thanks for the patch.
-Neil