Re: psql, tab completion additions

Lists: pgsql-patches
From: "Sergey E(dot) Koposov" <math(at)sai(dot)msu(dot)ru>
To: pgsql-patches(at)postgresql(dot)org
Subject: psql, tab completion additions
Date: 2005-11-29 03:40:11
Message-ID: Pine.LNX.4.44.0511290353030.3502-200000@lnfm1.sai.msu.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-patches

Hello All,

1) I'm proposing a patch to do the DROP FUNCTION argument tab completion.
Now, the arguments of the drop function can be tab completed. for example

drop function strpos (
<press tab>
drop FUNCTION strpos (text, text)

or:

wsdb=# drop FUNCTION length (
bit) bytea) character) lseg) path) text)
<press c>
wsdb# DROP FUNCTION length ( character)

I think that this patch should be rather useful. At it least I hate
always to type all the arguments of the dropped functions.

2) Also some fixes applied for the
CREATE INDEX syntax

now the parenthesises are inserted by tab pressing.
suppose I have the table q3c:
wsdb=# \d q3c
Table "public.q3c"
Column | Type | Modifiers
--------+------------------+-----------
ipix | bigint |
ra | double precision |
dec | double precision |

Now if I do
wsdb# create index xxx on q3c
<press tab>
wsdb# CREATE INDEX xxx on q3c (
<press tab>
wsdb=# CREATE INDEX xxx on q3c (
"dec" ipix ra
<press r>
wsdb=# CREATE INDEX xxx on q3c ( ra

Regards,
Sergey

*****************************************************
Sergey E. Koposov
Max-Planck Institut for Astronomy
Web: http://lnfm1.sai.msu.ru/~math
E-mail: math(at)sai(dot)msu(dot)ru

Attachment Content-Type Size
tab-complete.diff text/plain 2.6 KB

From: "Sergey E(dot) Koposov" <math(at)sai(dot)msu(dot)ru>
To: pgsql-patches(at)postgresql(dot)org
Subject: Re: psql, tab completion additions
Date: 2005-12-05 04:18:48
Message-ID: Pine.LNX.4.44.0512050715430.22088-200000@lnfm1.sai.msu.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-patches


Now the patch have been made using "cvs diff -c"

Sergey

On Tue, 29 Nov 2005, Sergey E. Koposov wrote:

> Hello All,
>
> 1) I'm proposing a patch to do the DROP FUNCTION argument tab completion.
> Now, the arguments of the drop function can be tab completed. for example
>
> drop function strpos (
> <press tab>
> drop FUNCTION strpos (text, text)
>
> or:
>
> wsdb=# drop FUNCTION length (
> bit) bytea) character) lseg) path) text)
> <press c>
> wsdb# DROP FUNCTION length ( character)
>
> I think that this patch should be rather useful. At it least I hate
> always to type all the arguments of the dropped functions.
>
> 2) Also some fixes applied for the
> CREATE INDEX syntax
>
> now the parenthesises are inserted by tab pressing.
> suppose I have the table q3c:
> wsdb=# \d q3c
> Table "public.q3c"
> Column | Type | Modifiers
> --------+------------------+-----------
> ipix | bigint |
> ra | double precision |
> dec | double precision |
>
> Now if I do
> wsdb# create index xxx on q3c
> <press tab>
> wsdb# CREATE INDEX xxx on q3c (
> <press tab>
> wsdb=# CREATE INDEX xxx on q3c (
> "dec" ipix ra
> <press r>
> wsdb=# CREATE INDEX xxx on q3c ( ra
>
> Regards,
> Sergey
>
> *****************************************************
> Sergey E. Koposov
> Max-Planck Institut for Astronomy
> Web: http://lnfm1.sai.msu.ru/~math
> E-mail: math(at)sai(dot)msu(dot)ru
>
>

*****************************************************
Sergey E. Koposov
Max-Planck Institut for Astronomy
Web: http://lnfm1.sai.msu.ru/~math
E-mail: math(at)sai(dot)msu(dot)ru

Attachment Content-Type Size
tab-complete.diff text/plain 3.8 KB

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: "Sergey E(dot) Koposov" <math(at)sai(dot)msu(dot)ru>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: psql, tab completion additions
Date: 2005-12-05 04:47:15
Message-ID: 200512050447.jB54lFa22041@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-patches


Previous version replaced.

Your patch has been added to the PostgreSQL unapplied patches list at:

http://momjian.postgresql.org/cgi-bin/pgpatches

It will be applied as soon as one of the PostgreSQL committers reviews
and approves it.

---------------------------------------------------------------------------

Sergey E. Koposov wrote:
>
> Now the patch have been made using "cvs diff -c"
>
> Sergey
>
> On Tue, 29 Nov 2005, Sergey E. Koposov wrote:
>
> > Hello All,
> >
> > 1) I'm proposing a patch to do the DROP FUNCTION argument tab completion.
> > Now, the arguments of the drop function can be tab completed. for example
> >
> > drop function strpos (
> > <press tab>
> > drop FUNCTION strpos (text, text)
> >
> > or:
> >
> > wsdb=# drop FUNCTION length (
> > bit) bytea) character) lseg) path) text)
> > <press c>
> > wsdb# DROP FUNCTION length ( character)
> >
> > I think that this patch should be rather useful. At it least I hate
> > always to type all the arguments of the dropped functions.
> >
> > 2) Also some fixes applied for the
> > CREATE INDEX syntax
> >
> > now the parenthesises are inserted by tab pressing.
> > suppose I have the table q3c:
> > wsdb=# \d q3c
> > Table "public.q3c"
> > Column | Type | Modifiers
> > --------+------------------+-----------
> > ipix | bigint |
> > ra | double precision |
> > dec | double precision |
> >
> > Now if I do
> > wsdb# create index xxx on q3c
> > <press tab>
> > wsdb# CREATE INDEX xxx on q3c (
> > <press tab>
> > wsdb=# CREATE INDEX xxx on q3c (
> > "dec" ipix ra
> > <press r>
> > wsdb=# CREATE INDEX xxx on q3c ( ra
> >
> > Regards,
> > Sergey
> >
> > *****************************************************
> > Sergey E. Koposov
> > Max-Planck Institut for Astronomy
> > Web: http://lnfm1.sai.msu.ru/~math
> > E-mail: math(at)sai(dot)msu(dot)ru
> >
> >
>
> *****************************************************
> Sergey E. Koposov
> Max-Planck Institut for Astronomy
> Web: http://lnfm1.sai.msu.ru/~math
> E-mail: math(at)sai(dot)msu(dot)ru
>

Content-Description:

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 1: if posting/reading through Usenet, please send an appropriate
> subscribe-nomail command to majordomo(at)postgresql(dot)org so that your
> message can get through to the mailing list cleanly

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073


From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: "Sergey E(dot) Koposov" <math(at)sai(dot)msu(dot)ru>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: psql, tab completion additions
Date: 2005-12-08 21:34:10
Message-ID: 200512082134.jB8LYAg26930@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-patches


Patch applied to CVS HEAD only. Thanks.

---------------------------------------------------------------------------

Sergey E. Koposov wrote:
>
> Now the patch have been made using "cvs diff -c"
>
> Sergey
>
> On Tue, 29 Nov 2005, Sergey E. Koposov wrote:
>
> > Hello All,
> >
> > 1) I'm proposing a patch to do the DROP FUNCTION argument tab completion.
> > Now, the arguments of the drop function can be tab completed. for example
> >
> > drop function strpos (
> > <press tab>
> > drop FUNCTION strpos (text, text)
> >
> > or:
> >
> > wsdb=# drop FUNCTION length (
> > bit) bytea) character) lseg) path) text)
> > <press c>
> > wsdb# DROP FUNCTION length ( character)
> >
> > I think that this patch should be rather useful. At it least I hate
> > always to type all the arguments of the dropped functions.
> >
> > 2) Also some fixes applied for the
> > CREATE INDEX syntax
> >
> > now the parenthesises are inserted by tab pressing.
> > suppose I have the table q3c:
> > wsdb=# \d q3c
> > Table "public.q3c"
> > Column | Type | Modifiers
> > --------+------------------+-----------
> > ipix | bigint |
> > ra | double precision |
> > dec | double precision |
> >
> > Now if I do
> > wsdb# create index xxx on q3c
> > <press tab>
> > wsdb# CREATE INDEX xxx on q3c (
> > <press tab>
> > wsdb=# CREATE INDEX xxx on q3c (
> > "dec" ipix ra
> > <press r>
> > wsdb=# CREATE INDEX xxx on q3c ( ra
> >
> > Regards,
> > Sergey
> >
> > *****************************************************
> > Sergey E. Koposov
> > Max-Planck Institut for Astronomy
> > Web: http://lnfm1.sai.msu.ru/~math
> > E-mail: math(at)sai(dot)msu(dot)ru
> >
> >
>
> *****************************************************
> Sergey E. Koposov
> Max-Planck Institut for Astronomy
> Web: http://lnfm1.sai.msu.ru/~math
> E-mail: math(at)sai(dot)msu(dot)ru
>

Content-Description:

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 1: if posting/reading through Usenet, please send an appropriate
> subscribe-nomail command to majordomo(at)postgresql(dot)org so that your
> message can get through to the mailing list cleanly

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073