Re: Bug while retrieving money data type from db

Hi,
I've stumbled into a bug, it seems the driver is not able to
retrive money data type from the db properly unless a getString
is used.... unfortunately in my case the code does not know
what kind of attributes is reading, and it uses getObject instead,
getting back an exception.

Running the attached code all I get is:

Exception in thread "main" org.postgresql.util.PSQLException: Il valore
«1,000.00» non è adeguato al tipo «double».
at
org.postgresql.jdbc2.AbstractJdbc2ResultSet.toDouble(AbstractJdbc2ResultSet.java:2645)
at
org.postgresql.jdbc2.AbstractJdbc2ResultSet.getDouble(AbstractJdbc2ResultSet.java:2032)
at
org.postgresql.jdbc2.AbstractJdbc2ResultSet.internalGetObject(AbstractJdbc2ResultSet.java:134)
at
org.postgresql.jdbc3.AbstractJdbc3ResultSet.internalGetObject(AbstractJdbc3ResultSet.java:39)
at
org.postgresql.jdbc2.AbstractJdbc2ResultSet.getObject(AbstractJdbc2ResultSet.java:2348)
at PgMoneyIssue.main(PgMoneyIssue.java:15)

(translated from italian, "the value 1,000.00 is not adequate for the
type double". Not sure if the problem is locale dependent, since it has
been reported as a GeoServer bug by a user living in USA, and I then
tracked it down to this issue with the driver).

I looked for a bug tracker but could not find one, so here I am, posting
the bug report to the ml.

Contact me back if you need any further information
Cheers
Andrea

On Tue, 26 Feb 2008, Andrea Aime wrote:

> I've stumbled into a bug, it seems the driver is not able to
> retrive money data type from the db properly unless a getString
> is used.... unfortunately in my case the code does not know
> what kind of attributes is reading, and it uses getObject instead,
> getting back an exception.

We already knew the support for money in the driver was pretty poor (it
doesn't work for locale's whose currency symbol is not $), but the fact
that it doesn't support separators makes it especially useless.
Since every getInt/Float/... call is paying a performance price for
checking for the money type and doesn't always work, I suggest we rip all
that out and return money as either a String or the PGmoney type.

That will break existing applications that want to be able to do getDouble
on money data, but I'm OK with that because they should be pretty rare.

Kris Jurka

Hello Kris,

Kris Jurka schrieb:
> That will break existing applications that want to be able to do
> getDouble on money data, but I'm OK with that because they should be
> pretty rare.
If you are on breaking existing applications anyway, please reconsider
my patch given in the Thread with the name "[JDBC] TypeInfoCache" :))
>
> Kris Jurka
With best regards,
Daniel Migowski

PS: This patch even enables an application, namely Chrystal Reports JDBC
Implementation (which is not so rare).

On Fri, 29 Feb 2008, Daniel Migowski wrote:

> Kris Jurka schrieb:
>> That will break existing applications that want to be able to do getDouble
>> on money data, but I'm OK with that because they should be pretty rare.
>
> If you are on breaking existing applications anyway, please reconsider my
> patch given in the Thread with the name "[JDBC] TypeInfoCache" :))
>

I still don't like your patch, but I am planning on implementing the
solution that Oliver and I liked better (making up a bogus precision for
types without lengths).

http://pgfoundry.org/tracker/index.php?func=detail&aid=1010277&group_id=1000224&atid=854

Kris Jurka