Lists: | pgsql-hackerspgsql-patches |
---|
From: | "Larry Rosenman" <lrosenman(at)pervasive(dot)com> |
---|---|
To: | "Jim Nasby" <jnasby(at)pervasive(dot)com> |
Cc: | <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Logging pg_autovacuum |
Date: | 2006-05-01 18:15:13 |
Message-ID: | F6616E0E81AC0841B1F9DD252F7C4B55041A4D@ausmaildd.aus.pervasive.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-hackers pgsql-patches |
Jim C. Nasby wrote:
> On Mon, May 01, 2006 at 12:28:21PM -0500, Larry Rosenman wrote:
>> Since both vacuum and autovacuum will be cutting stats records, do we
>> want to just have the autovacuum
>> stats record have the fact that it was autovacuum that did the
>> vacuum?
>>
>> Or, is there a way when vacuum is run by autovacuum that I can get a
>> flag to set that says this (vacuum|analyze) was done by the
>> autovacuum daemon?
>>
>> I agree that the existing stats calls are good, but I'm still reading
>> code to see whether I can determine
>> at the time they are cut that this was autovacuum that did it.
>
> I think noting autovac vacuums/analyzes seperately is 'nice-to-have'
> but not all that important. It'd probably be pretty easy to tell the
> difference just knowing what (if any) manual vacuums your system runs.
>
> While we're looking at logging, are you going to add stats stuff for
> the bgwriter as well, or should we add this to the TODO?
I was going to do that after I got some comfort with what I'm doing
here.
--
Larry Rosenman
Database Support Engineer
PERVASIVE SOFTWARE. INC.
12365B RIATA TRACE PKWY
3015
AUSTIN TX 78727-6531
Tel: 512.231.6173
Fax: 512.231.6597
Email: Larry(dot)Rosenman(at)pervasive(dot)com
Web: www.pervasive.com
From: | "Larry Rosenman" <ler(at)lerctr(dot)org> |
---|---|
To: | "Larry Rosenman" <lrosenman(at)pervasive(dot)com>, "Jim Nasby" <jnasby(at)pervasive(dot)com> |
Cc: | <pgsql-hackers(at)postgresql(dot)org>, <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: [HACKERS] Logging pg_autovacuum |
Date: | 2006-05-01 21:14:04 |
Message-ID: | 008201c66d64$2d3b5c60$aa0610ac@aus.pervasive.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-hackers pgsql-patches |
Larry Rosenman wrote:
> Jim C. Nasby wrote:
>> On Mon, May 01, 2006 at 12:28:21PM -0500, Larry Rosenman wrote:
>>> Since both vacuum and autovacuum will be cutting stats records, do
>>> we want to just have the autovacuum
>>> stats record have the fact that it was autovacuum that did the
>>> vacuum?
>>>
>>> Or, is there a way when vacuum is run by autovacuum that I can get a
>>> flag to set that says this (vacuum|analyze) was done by the
>>> autovacuum daemon?
>>>
>>> I agree that the existing stats calls are good, but I'm still
>>> reading code to see whether I can determine
>>> at the time they are cut that this was autovacuum that did it.
>>
>> I think noting autovac vacuums/analyzes seperately is
pg-dev/vacuum-time-patch-WIP.txt'nice-to-have'
>> but not all that important. It'd probably be pretty easy to tell the
>> difference just knowing what (if any) manual vacuums your system
>> runs.
>>
>> While we're looking at logging, are you going to add stats stuff for
>> the bgwriter as well, or should we add this to the TODO?
>
> I was going to do that after I got some comfort with what I'm doing
> here.
I've put a WIP patch up for comments:
http://www.lerctr.org/~ler/pg-dev/vacuum-time-patch-WIP.txt
this is *NOT* for application, as I still need to add access to the new
fields to
the views, etc.
I'm looking to get comments on it.
--
Larry Rosenman http://www.lerctr.org/~ler
Phone: +1 512-248-2683 E-Mail: ler(at)lerctr(dot)org
US Mail: 430 Valona Loop, Round Rock, TX 78681-3893