| Lists: | pgsql-committerspgsql-hackers |
|---|
| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | pgsql-committers(at)postgresql(dot)org |
| Subject: | pgsql: Move rmtree() from libpgport to libpgcommon |
| Date: | 2013-10-19 14:21:42 |
| Message-ID: | E1VXXPS-0003su-VS@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-committers pgsql-hackers |
Move rmtree() from libpgport to libpgcommon
It requires pgfnames() from libpgcommon.
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/2e6bc4b806ca92433932b34c019293a201f03e11
Modified Files
--------------
src/bin/initdb/nls.mk | 2 +-
src/common/Makefile | 2 +-
src/common/rmtree.c | 131 +++++++++++++++++++++++++++++++++++++++++++
src/port/dirmod.c | 110 ------------------------------------
src/tools/msvc/Mkvcbuild.pm | 2 +-
5 files changed, 134 insertions(+), 113 deletions(-)
| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | pgsql-hackers(at)postgreSQL(dot)org |
| Subject: | Re: [COMMITTERS] pgsql: Move rmtree() from libpgport to libpgcommon |
| Date: | 2013-10-25 02:44:57 |
| Message-ID: | 12899.1382669097@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-committers pgsql-hackers |
Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> Move rmtree() from libpgport to libpgcommon
This patch leaves dirmod.c entirely empty on non-Windows platforms.
At least on my OS X Lion laptop, that results in some bleating:
/usr/bin/ranlib: file: libpgport.a(dirmod.o) has no symbols
/usr/bin/ranlib: file: libpgport_srv.a(dirmod_srv.o) has no symbols
Can we do something about that? Perhaps not build this file on
non-Windows?
regards, tom lane