| Lists: | pgsql-committerspgsql-hackers |
|---|
| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | pgsql-committers(at)postgresql(dot)org |
| Subject: | pgsql: Remove prepared transactions from main isolation test schedule. |
| Date: | 2012-07-20 19:57:41 |
| Message-ID: | E1SsJKX-0001zA-Pd@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-committers pgsql-hackers |
Remove prepared transactions from main isolation test schedule.
There is no point in running this test when prepared transactions are disabled,
which is the default. New make targets that include the test are provided. This
will save some useless waste of cycles on buildfarm machines.
Backpatch to 9.1 where these tests were introduced.
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/ae55d9fbe3871a5e6309d9b91629f1b0ff2b8cba
Modified Files
--------------
src/test/isolation/Makefile | 10 ++++++++++
src/test/isolation/isolation_schedule | 1 -
2 files changed, 10 insertions(+), 1 deletions(-)
| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | pgsql-hackers(at)postgreSQL(dot)org |
| Subject: | Re: [COMMITTERS] pgsql: Remove prepared transactions from main isolation test schedule. |
| Date: | 2012-07-20 20:17:08 |
| Message-ID: | 500.1342815428@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-committers pgsql-hackers |
Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> Remove prepared transactions from main isolation test schedule.
> There is no point in running this test when prepared transactions are disabled,
> which is the default. New make targets that include the test are provided. This
> will save some useless waste of cycles on buildfarm machines.
Having done that, shouldn't we remove prepared-transactions_1.out (the
"expected" file for the prepared-transactions-disabled case)?
Having a megabyte-sized test file for that case has always seemed pretty
wasteful to me. Now that the test won't be run unless intentionally
selected, it seems like people who are using it would expect it to
actually test prepared transactions --- so having it "pass" when they're
disabled seems wrong.
regards, tom lane
| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers(at)postgreSQL(dot)org |
| Subject: | Re: [COMMITTERS] pgsql: Remove prepared transactions from main isolation test schedule. |
| Date: | 2012-07-20 20:21:35 |
| Message-ID: | 5009BDCF.8030603@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-committers pgsql-hackers |
On 07/20/2012 04:17 PM, Tom Lane wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>> Remove prepared transactions from main isolation test schedule.
>> There is no point in running this test when prepared transactions are disabled,
>> which is the default. New make targets that include the test are provided. This
>> will save some useless waste of cycles on buildfarm machines.
> Having done that, shouldn't we remove prepared-transactions_1.out (the
> "expected" file for the prepared-transactions-disabled case)?
>
> Having a megabyte-sized test file for that case has always seemed pretty
> wasteful to me. Now that the test won't be run unless intentionally
> selected, it seems like people who are using it would expect it to
> actually test prepared transactions --- so having it "pass" when they're
> disabled seems wrong.
>
>
Good point. Will do.
cheers
andrew