pgsql: Self review of previous patch. Fix assumption that xmax >= xmin.

Lists: pgsql-committers
From: Simon Riggs <simon(at)2ndQuadrant(dot)com>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Self review of previous patch. Fix assumption that xmax >= xmin.
Date: 2010-12-09 10:22:35
Message-ID: E1PQddz-0006AW-1Z@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-committers

Self review of previous patch. Fix assumption that xmax >= xmin.

Branch
------
master

Details
-------
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=9975c683b102d06ed5d5ab799eaba0d00a9ff38c

Modified Files
--------------
src/backend/access/heap/heapam.c | 6 ++----
1 files changed, 2 insertions(+), 4 deletions(-)

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Simon Riggs <simon(at)2ndquadrant(dot)com>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Self review of previous patch. Fix assumption that xmax >= xmin.
Date: 2010-12-13 08:02:38
Message-ID: AANLkTimqY=aFXNcq_sdjf0tWiLw_E+ROaD391OoB7eEv@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-committers

On Thu, Dec 9, 2010 at 7:22 PM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
> Self review of previous patch. Fix assumption that xmax >= xmin.

This seems to require backporting. No?

Regards,

--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

From: Simon Riggs <simon(at)2ndQuadrant(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Self review of previous patch. Fix assumption that xmax >= xmin.
Date: 2010-12-13 12:56:46
Message-ID: 1292245006.2737.2875.camel@ebony
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-committers

On Mon, 2010-12-13 at 17:02 +0900, Fujii Masao wrote:
> On Thu, Dec 9, 2010 at 7:22 PM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
> > Self review of previous patch. Fix assumption that xmax >= xmin.
>
> This seems to require backporting. No?

Already done.

--
Simon Riggs http://www.2ndQuadrant.com/books/
PostgreSQL Development, 24x7 Support, Training and Services

From: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
To: Simon Riggs <simon(at)2ndQuadrant(dot)com>
Cc: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Self review of previous patch. Fix assumption that xmax >= xmin.
Date: 2010-12-13 13:23:03
Message-ID: 4D061E37.2020507@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-committers

On 13.12.2010 14:56, Simon Riggs wrote:
> On Mon, 2010-12-13 at 17:02 +0900, Fujii Masao wrote:
>> On Thu, Dec 9, 2010 at 7:22 PM, Simon Riggs<simon(at)2ndquadrant(dot)com> wrote:
>>> Self review of previous patch. Fix assumption that xmax>= xmin.
>>
>> This seems to require backporting. No?
>
> Already done.

Nope, that follow-on patch is not in REL9_0_STABLE.

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com

From: Simon Riggs <simon(at)2ndQuadrant(dot)com>
To: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
Cc: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Self review of previous patch. Fix assumption that xmax >= xmin.
Date: 2010-12-13 14:01:47
Message-ID: 1292248907.2737.2943.camel@ebony
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-committers

On Mon, 2010-12-13 at 15:23 +0200, Heikki Linnakangas wrote:
> On 13.12.2010 14:56, Simon Riggs wrote:
> > On Mon, 2010-12-13 at 17:02 +0900, Fujii Masao wrote:
> >> On Thu, Dec 9, 2010 at 7:22 PM, Simon Riggs<simon(at)2ndquadrant(dot)com> wrote:
> >>> Self review of previous patch. Fix assumption that xmax>= xmin.
> >>
> >> This seems to require backporting. No?
> >
> > Already done.
>
> Nope, that follow-on patch is not in REL9_0_STABLE.

Yes, it is.

The work was bundled together and the commit messages differ.

--
Simon Riggs http://www.2ndQuadrant.com/books/
PostgreSQL Development, 24x7 Support, Training and Services

From: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
To: Simon Riggs <simon(at)2ndQuadrant(dot)com>
Cc: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Self review of previous patch. Fix assumption that xmax >= xmin.
Date: 2010-12-13 14:10:47
Message-ID: 4D062967.8000501@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-committers

On 13.12.2010 16:01, Simon Riggs wrote:
> On Mon, 2010-12-13 at 15:23 +0200, Heikki Linnakangas wrote:
>> On 13.12.2010 14:56, Simon Riggs wrote:
>>> On Mon, 2010-12-13 at 17:02 +0900, Fujii Masao wrote:
>>>> On Thu, Dec 9, 2010 at 7:22 PM, Simon Riggs<simon(at)2ndquadrant(dot)com> wrote:
>>>>> Self review of previous patch. Fix assumption that xmax>= xmin.
>>>>
>>>> This seems to require backporting. No?
>>>
>>> Already done.
>>
>> Nope, that follow-on patch is not in REL9_0_STABLE.
>
> Yes, it is.
>
> The work was bundled together and the commit messages differ.

No, it's not. See for yourself:

http://git.postgresql.org/gitweb?p=postgresql.git;a=blob;f=src/backend/access/heap/heapam.c;h=1c934007b2edbe97e548a7e84fe5802b6b8c5c98;hb=refs/heads/REL9_0_STABLE#l3812

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com

From: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
To: Simon Riggs <simon(at)2ndQuadrant(dot)com>
Cc: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Self review of previous patch. Fix assumption that xmax >= xmin.
Date: 2010-12-13 14:17:15
Message-ID: 4D062AEB.6000906@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-committers

On 13.12.2010 16:10, Heikki Linnakangas wrote:
> On 13.12.2010 16:01, Simon Riggs wrote:
>> On Mon, 2010-12-13 at 15:23 +0200, Heikki Linnakangas wrote:
>>> On 13.12.2010 14:56, Simon Riggs wrote:
>>>> On Mon, 2010-12-13 at 17:02 +0900, Fujii Masao wrote:
>>>>> On Thu, Dec 9, 2010 at 7:22 PM, Simon Riggs<simon(at)2ndquadrant(dot)com>
>>>>> wrote:
>>>>>> Self review of previous patch. Fix assumption that xmax>= xmin.
>>>>>
>>>>> This seems to require backporting. No?
>>>>
>>>> Already done.
>>>
>>> Nope, that follow-on patch is not in REL9_0_STABLE.
>>
>> Yes, it is.
>>
>> The work was bundled together and the commit messages differ.
>
> No, it's not. See for yourself:
>
> http://git.postgresql.org/gitweb?p=postgresql.git;a=blob;f=src/backend/access/heap/heapam.c;h=1c934007b2edbe97e548a7e84fe5802b6b8c5c98;hb=refs/heads/REL9_0_STABLE#l3812

Sorry, I was wrong and you were right. Looks like I need to visit the
optician...

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
Cc: Simon Riggs <simon(at)2ndquadrant(dot)com>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Self review of previous patch. Fix assumption that xmax >= xmin.
Date: 2010-12-13 15:09:17
Message-ID: AANLkTikvVCzZDEdKdTZua6+BYT6JPgzfnwkEh9=QzX84@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-committers

On Mon, Dec 13, 2010 at 11:17 PM, Heikki Linnakangas
<heikki(dot)linnakangas(at)enterprisedb(dot)com> wrote:
> Sorry, I was wrong and you were right. Looks like I need to visit the
> optician...

Well, me too... Sorry for the noise.

Regards,

--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

From: Simon Riggs <simon(at)2ndQuadrant(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Self review of previous patch. Fix assumption that xmax >= xmin.
Date: 2010-12-13 15:20:36
Message-ID: 1292253636.2737.3100.camel@ebony
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-committers

On Tue, 2010-12-14 at 00:09 +0900, Fujii Masao wrote:
> On Mon, Dec 13, 2010 at 11:17 PM, Heikki Linnakangas
> <heikki(dot)linnakangas(at)enterprisedb(dot)com> wrote:
> > Sorry, I was wrong and you were right. Looks like I need to visit the
> > optician...
>
> Well, me too... Sorry for the noise.

No problems, thanks for checking my work.

--
Simon Riggs http://www.2ndQuadrant.com/books/
PostgreSQL Development, 24x7 Support, Training and Services